-
Notifications
You must be signed in to change notification settings - Fork 21
feat(pkg-py): Add .app() method, enable bookmarking by default
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0238dac to
0a41a59
Compare
60e9b32 to
8e699a5
Compare
8e699a5 to
890d87b
Compare
gadenbuie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
| # Reactive values to store state | ||
| sql = ReactiveString("") | ||
| title = ReactiveStringOrNone(None) | ||
| has_greeted = reactive.value[bool](False) # noqa: FBT003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember this from the R side, are we missing it over there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, yea. Filed #107 to make sure we don't forget
Closes #69